This repository has been archived by the owner on Jun 19, 2023. It is now read-only.
remove Wrap #21
Merged
remove Wrap #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be trivially implemented by the end-user if desired. The best the CoreAPI can do is name the file with it's own hash so this isn't really all that helpful either. Note: This differs from js-ipfs because _there_, all files have paths (even outside directories).
magik6k
approved these changes
Mar 22, 2019
Stebalien
force-pushed
the
feat/remove-wrap
branch
from
19b6c4e
to
17e62ca
Compare
|
Should we merge this outside ipfs/kubo#6121, so that no one uses it when it's about to be removed? |
|
Yeah, that sounds like a good idea (although we'll need a PR to remove support in go-ipfs first, do you have time to put one together?). |
magik6k
force-pushed
the
feat/remove-wrap
branch
from
17e62ca
to
33e0648
Compare
guseggert
pushed a commit
to ipfs/boxo
that referenced
this pull request
Dec 6, 2022
…ve-wrap remove Wrap This commit was moved from ipfs/interface-go-ipfs-core@c35356b
guseggert
pushed a commit
to ipfs/boxo
that referenced
this pull request
Mar 15, 2023
…ve-wrap remove Wrap This commit was moved from ipfs/interface-go-ipfs-core@c35356b
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be trivially implemented by the end-user if desired. The best the CoreAPI can do is name the file with it's own hash so this isn't really all that helpful either.
Note: This differs from js-ipfs because there, all files have paths (even outside directories).
part of ipfs/kubo#6121