fix: use a short-lived AbortSignal for fetch operations #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node's `undici` module appears to be adding listeners for the `"abort"` event on any passed AbortSignal but then not cleaning them up. This casues many `MaxListenersExceededWarning`s to appear in the console and likely causes a memory leak. To work around this, use a short-lived `AbortSignal` for each request that can be garbage collected along with the request itself. See https://github.com/nodejs/node/issues/52635 for more information.
achingbrain
force-pushed
the
fix/maxlistenersexceededwarning-in-http-blockbroker
branch
from
1d3a4f9
to
e146dc3
Compare
5 tasks
SgtPooki
approved these changes
Apr 22, 2024
achingbrain
deleted the
fix/maxlistenersexceededwarning-in-http-blockbroker
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node's
undicimodule appears to be adding listeners for the"abort"event on any passed AbortSignal but then not cleaning them up.This casues many
MaxListenersExceededWarnings to appear in the console and likely causes a memory leak.To work around this, use a short-lived
AbortSignalfor each request that can be garbage collected along with the request itself and trigger"abort"on it if the long-lived signal aborts, taking care to remove any added listeners once we are done with the request.See nodejs/undici#3157 for more information.
Change checklist