Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

Fix incorrect mutex unlock call in File.Open #82

Merged
merged 1 commit into from
May 14, 2020
Merged

Fix incorrect mutex unlock call in File.Open #82

merged 1 commit into from
May 14, 2020

Conversation

djdv
Copy link
Contributor

@djdv djdv commented May 14, 2020

A File's read mutex is locked when entering the call to open with read only flags, but the mutex's write lock is being requested to release when/if defer sees an error in the call to File.Open.

@djdv djdv requested a review from schomatis as a code owner May 14, 2020 23:06
@welcome
Copy link

welcome bot commented May 14, 2020

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@Stebalien Stebalien merged commit 9c9a0fe into ipfs:master May 14, 2020
@Stebalien Stebalien mentioned this pull request May 26, 2020
77 tasks
Jorropo pushed a commit to ipfs/go-libipfs-rapide that referenced this pull request Mar 23, 2023
Fix incorrect mutex unlock call in File.Open

This commit was moved from ipfs/go-mfs@9c9a0fe
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants