-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(*ProtoNode).RawData
use incorrectly panic instead of returning
#90
Comments
Gentle approach: #91 Proper approach is to stick an |
Ref: ipfs/go-merkledag#90 This commit was moved from ipfs/go-merkledag@bb220e8
Where this was found: ipfs/kubo#9297
(*ProtoNode).RawData
use incorrectly panics, there are cases where consumers can because of bad options trigger an error.My dumb first instict would be to make it return
([]byte, error)
but AFAIT this is trying to fit an interface so we can't do this.I guess the alternative is to do the serialisation in the write functions (which do return errors) and save the serialised bytes instead.
The text was updated successfully, but these errors were encountered: