Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

fix: require V2 signatures #41

Merged
merged 4 commits into from
Sep 20, 2022
Merged

fix: require V2 signatures #41

merged 4 commits into from
Sep 20, 2022

Conversation

lidel
Copy link
Member

@lidel lidel commented Sep 12, 2022

This PR is a part of deprecation described in ipfs/kubo#9240

  • record Create continues to create records with both V1 and V2 signatures
  • record Validate no longer accepts V1 signatures

Meaning:

  • modern nodes are 100% V2, they ignore V1 signatures
  • legacy nodes (go-ipfs < v0.9.0) are still able to resolve names created by go-ipns, because V1 is still present

This is part of deprecation described in ipfs/kubo#9240
- record creation continues to create both V1 and V2  signatures
- record validation no longer accepts V1 signatures

Meaning:
- modern nodes are 100% V2, they ignore V1 signatures
- legacy nodes (go-ipfs < v0.9.0) are still able to resolve names
  created by go-ipns, because V1 is still present
@ipfs ipfs deleted a comment from welcome bot Sep 12, 2022
@lidel lidel marked this pull request as ready for review September 12, 2022 19:55
ipns.go Outdated Show resolved Hide resolved
@github-actions
Copy link

Suggested version: v0.3.0
Comparing to: v0.2.0 (diff)

Changes in go.mod file(s):

(empty)

gorelease says:

# github.com/ipfs/go-ipns
## compatible changes
ErrRecordSize: added
MaxRecordSize: added

# summary
Suggested version: v0.3.0

gocompat says:

(empty)

@lidel lidel merged commit 1af8e5c into master Sep 20, 2022
@lidel lidel deleted the chore/require-v2-signatures branch September 20, 2022 22:31
Jorropo pushed a commit to ipfs/go-libipfs-rapide that referenced this pull request Mar 23, 2023
Jorropo pushed a commit to ipfs/go-libipfs-rapide that referenced this pull request Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants