Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coreapi: remove Unixfs.Wrap #6123

Merged
merged 2 commits into from
Mar 25, 2019
Merged

coreapi: remove Unixfs.Wrap #6123

merged 2 commits into from
Mar 25, 2019

Conversation

magik6k
Copy link
Member

@magik6k magik6k commented Mar 25, 2019

Simplified version of #6121, just removing Wrap from CoreAPI / Adder

Depends on ipfs/interface-go-ipfs-core#21

@magik6k
coreapi: remove Unixfs.Wrap
95906d3 
License: MIT
Signed-off-by: Łukasz Magiera <[email protected]>
@magik6k magik6k requested a review from Kubuxu as a code owner March 25, 2019 18:02
@ghost ghost assigned magik6k Mar 25, 2019
@ghost ghost added the status/in-progress In progress label Mar 25, 2019
@magik6k magik6k mentioned this pull request Mar 25, 2019
Merged
Stebalien
Stebalien approved these changes Mar 25, 2019
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've merged the interface changes as well, can you tag a release? (don't bother with pulling a gx update).

@magik6k
gomod: update coreiface
353dd67 
License: MIT
Signed-off-by: Łukasz Magiera <[email protected]>
@magik6k
Copy link
Member Author

magik6k commented Mar 25, 2019

(done)

@Stebalien Stebalien merged commit 7be3cd5 into master Mar 25, 2019
@Stebalien Stebalien deleted the coreapi/remove/wrap branch March 25, 2019 18:50
@ghost ghost removed the status/in-progress In progress label Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

Assignees

@magik6k magik6k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magik6k @Stebalien