Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

object: --quiet flag to put #4411

Merged
merged 1 commit into from
Nov 21, 2017
Merged

object: --quiet flag to put #4411

merged 1 commit into from
Nov 21, 2017

Conversation

magik6k
Copy link
Member

@magik6k magik6k commented Nov 21, 2017

Like --quitet for ipfs add, makes use in scripts a bit simpler.

License: MIT
Signed-off-by: Łukasz Magiera <[email protected]>
@magik6k
Copy link
Member Author

magik6k commented Nov 21, 2017

Random test fails on Jenkins:

18:43:44.541 ERROR    bitswap: nil cid in GetBlock get.go:18
--- FAIL: TestBasicBitswap (5.02s)
	bitswap_test.go:320: Test a one node trying to get one block from another
	bitswap_test.go:345: should have no items in other peers wantlist
FAIL
FAIL	github.com/ipfs/go-ipfs/exchange/bitswap	15.989s
ok 11 - long running command shows up

expecting success: 
  grep "log/tail" cmd_out2 | grep "true" > /dev/null

not ok 12 - output looks good
#	
#	  grep "log/tail" cmd_out2 | grep "true" > /dev/null
#	
expecting success: 

  kill $LOGPID
  go-sleep 0.5s
  kill $LOGPID
  wait $LOGPID || true

Error: request canceled
./t0065-active-requests.sh: 4: kill: No such process
not ok 4 - 'ipfs repo stat' RepoSize is correct with sym link
#	
#	  export IPFS_PATH="sym_link_target" &&
#	  reposize_direct=$(ipfs repo stat | grep RepoSize | awk '{ print $2 }') &&
#	  export IPFS_PATH=".ipfs" &&
#	  reposize_symlink=$(ipfs repo stat | grep RepoSize | awk '{ print $2 }') &&
#	  test $reposize_symlink -ge $reposize_direct
#	

# failed 1 among 4 test(s)
1..4
test/sharness/Rules.mk:31: recipe for target 'test/sharness/t0088-repo-stat-symlink.sh' failed
expecting success: 
  ma-pipe-unidir --listen --pidFile=listener.pid recv /ip4/127.0.0.1/tcp/10101 > server.out &

  test_wait_for_file 30 100ms listener.pid &&
  kill -0 $(cat listener.pid) &&

  ipfsi 1 p2p stream dial $PEERID_0 p2p-test /ip4/127.0.0.1/tcp/10102 2>&1 > dialer-stdouterr.log &&
  ma-pipe-unidir send /ip4/127.0.0.1/tcp/10102 < test1.bin &&
  go-sleep 250ms &&
  test ! -f listener.pid

not ok 13 - Test client to server communications
#	
#	  ma-pipe-unidir --listen --pidFile=listener.pid recv /ip4/127.0.0.1/tcp/10101 > server.out &
#	
#	  test_wait_for_file 30 100ms listener.pid &&
#	  kill -0 $(cat listener.pid) &&
#	
#	  ipfsi 1 p2p stream dial $PEERID_0 p2p-test /ip4/127.0.0.1/tcp/10102 2>&1 > dialer-stdouterr.log &&
#	  ma-pipe-unidir send /ip4/127.0.0.1/tcp/10102 < test1.bin &&
#	  go-sleep 250ms &&
#	  test ! -f listener.pid
#	

https://ci.ipfs.team/blue/rest/organizations/jenkins/pipelines/go-ipfs/branches/PR-4411/runs/1/nodes/70/steps/80/log/?start=0

This was referenced Nov 21, 2017
@whyrusleeping whyrusleeping merged commit 586dd65 into master Nov 21, 2017
@whyrusleeping whyrusleeping deleted the feat/objput-quiet branch November 21, 2017 23:01
@magik6k magik6k restored the feat/objput-quiet branch November 27, 2017 03:34
@magik6k magik6k deleted the feat/objput-quiet branch November 27, 2017 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants