assets: add [email protected] GPG key

[ghost]

I'll see if I have to update hashes in the tests...

Resolves #3256

License: MIT
Signed-off-by: Lars Gierth [email protected]

[Kubuxu]

@lgierth you made tests very upset

[ghost]

I had to resurrect the vendored dir-index-html package -- this was the second time already that it was purged so I made the dependency a little more obvious for automated tools. Let's see how it goes.

[ghost]

I think this is now dependent on go1.7 which made GOVENDOREXPERIMENT=1 the builtin default (or was it 1.6)

[ghost]

The yak is not nearly shaved -- after resurrecting dir-index-html (again!) in a hacky way, now js-ipfs-api needs fixes to its tests...

At least go-ipfs itself is green now.

[whyrusleeping]

@lgierth we have gx for real now, we should probably just try and use it for dir-index-html (doesnt have to be now, but in the future)

[ghost]

@lgierth we have gx for real now, we should probably just try and use it for dir-index-html (doesnt have to be now, but in the future)

I am using gx for it now :)

[whyrusleeping]

Oh, gotcha, carry on

[ghost]

I know these paths are very hacky, but they're only ever used when running cd assets/ && go generate -- I think this is a use case for gx as a library.

import gx "github.com/whyrusleeping/gx-go/lib"

var dirIndexPkg = "/ipfs/QmQfeKxQtBN721pekQh6Jq24adFUjnU65YdY3GNczfuG2T/dir-index-html"
var initDirIndex = []string{
    filepath.join(gx.PathTo(dirIndexPkg), "knownIcons.txt"),
    filepath.join(gx.PathTo(dirIndexPkg), "dir-index.html"),
}

Or is there simply a way to get GOPATH? I didn't find one.

[jbenet]

gx-lib could install it in the local dir with an option Or something

On Sun, Sep 4, 2016, 23:32 Lars Gierth [email protected] wrote:

In assets/assets.go
#2997 (comment):

@@ -30,8 +32,10 @@ func SeedInitDocs(nd _core.IpfsNode) (_key.Key, error) {
}

var initDirIndex = []string{

• filepath.Join("..", "vendor", "dir-index-html-v1.0.0", "knownIcons.txt"),
• filepath.Join("..", "vendor", "dir-index-html-v1.0.0", "dir-index.html"),
• // assumes path to this file (assets.go) is:
• // $GOPATH/src/github.com/ipfs/go-ipfs/assets/assets.go
• filepath.Join("..", "..", "..", "..", "gx", "ipfs", "QmQfeKxQtBN721pekQh6Jq24adFUjnU65YdY3GNczfuG2T", "dir-index-html", "knownIcons.txt"),
• filepath.Join("..", "..", "..", "..", "gx", "ipfs", "QmQfeKxQtBN721pekQh6Jq24adFUjnU65YdY3GNczfuG2T", "dir-index-html", "dir-index.html"),

I know these paths are very hacky, but they're only ever used when running cd
assets/ && go generate -- I think this is a use case for gx as a library.

import gx "github.com/whyrusleeping/gx-go/lib"
var dirIndexPkg = "/ipfs/QmQfeKxQtBN721pekQh6Jq24adFUjnU65YdY3GNczfuG2T/dir-index-html"var initDirIndex = []string{
filepath.join(gx.PathTo(dirIndexPkg), "knownIcons.txt"),
filepath.join(gx.PathTo(dirIndexPkg), "dir-index.html"),
}

Or is there simply a way to get GOPATH? I didn't find one.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ipfs/go-ipfs/pull/2997/files/51467b79a7b24f5955143fc5a5f2243399b40568#r77459063,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIcoX5QVX0NCserADHOQ5DeGYjXUGSwks5qmzjmgaJpZM4JWRp7
.

[whyrusleeping]

@lgierth os.Getenv("GOPATH")

[ghost]

Blocked for now, gonna give this another go once ipfs-inactive/js-ipfs-http-client#365 is resolved

[ghost]

rebased, travis failure looks unrelated: https://s3.amazonaws.com/archive.travis-ci.org/jobs/163734715/log.txt

[Kubuxu]

Can you also resolve #3256 in this PR (so we don't spam the rebuild of bindata), I think file with content like IPFS is active\n should be enough.

[ghost]

Updated, this now also incorporates #3256 -- cc @Kubuxu you owe me a code review :)

[whyrusleeping]

@lgierth @Kubuxu updates here?

[ghost]

Sigh now it conflicts again

[ghost]

It's good to go now

[Kubuxu]

LGTM

[Kubuxu]

@lgierth can you resolve the conflict and can we get it merged @whyrusleeping

[Kubuxu]

Can you also resolve #3184 in this PR?

[ghost]

Can you also resolve #3184 in this PR?

This will have to wait, sorry

[ghost]

Sigh, now it's conflicting again

[ghost]

rebased