-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Query Parameters? #20
Comments
Code now parses and `MatchAndExpandPlaceholders` for query parameters as well as paths. Placeholders are shared between the two. This commit codifies some of the previously implicit edgecases, particularly around duplicate placeholders. Closes ipfs#20
I ended up implementing it anyway 😅 Let me know your thoughts! |
Code now parses and `MatchAndExpandPlaceholders` for query parameters as well as paths. Placeholders are shared between the two. This commit codifies some of the previously implicit edgecases, particularly around duplicate placeholders. Closes ipfs#20
Code now parses and `MatchAndExpandPlaceholders` for query parameters as well as paths. Placeholders are shared between the two. This commit codifies some of the previously implicit edgecases, particularly around duplicate placeholders. Closes ipfs#20
Code now parses and `MatchAndExpandPlaceholders` for query parameters as well as paths. Placeholders are shared between the two. This commit codifies some of the previously implicit edgecases, particularly around duplicate placeholders. Closes ipfs#20
This is effectively a spec change so should be resolved via a proposed IPIP change (https://github.com/ipfs/specs/tree/main#interplanetary-improvement-process-ipip) in https://github.com/ipfs/specs. The proposal template highlights some questions around benefits, alternatives, tradeoffs, etc. that would likely be helpful to reviewers. From what I can tell it seems like this could potentially introduce problems for users as new proposals come along that natively add query parameters to the URI such as IPIP-402. It would effectively add a sense of non-reproducibility to |
Thank you so much @aschmahmann! This is super helpful feedback; I'll review IPIP-402 (and any others referencing the HTTP gateway) and build an IPIP of my own. |
Would IPFS be interested in supporting
_redirects
files with query parameters, similar to Netlify)? (Re: ipfs/kubo#8890). If this seems valuable, I'd put a PR together (here and in ipfs/kubo).I would find it valuable to be able to write a redirects file similar to the one below, to be able to provide responses to 'dynamic-looking' web-requests (from clients that expect to use specific, query parameter-based, GET APIs) via IPFS:
(This is identical to the format Netlify uses — only required parameters must be specified.)
GET /things?type=photos
→ Served from/things/photos.html
GET /things
→ Served from/things.html
The text was updated successfully, but these errors were encountered: