support url paths as files.WebFile #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
Mar 21, 2019
|
LGTM. Can you rebase on master (has a v0.0.2 release). |
|
Just realized that this is probably the first ipfs-cluster feature that has been back-ported to go-ipfs 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
cliparser to createfiles.WebFiles for URL paths.It also updates thego-ipfs-filesdependency tov0.0.2(to supportnocopyfrom ipfs/go-ipfs-files#13). This version is not strictly required to compile or use URLs alone (what really matter is which versiongo-ipfsuses), but simplifies things by couplingnocopysupport from the start.Towards ipfs/kubo#6065
Draft untilgo-ipfs-filesv0.0.2is released.