tweak the default options #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Disable CompactL0OnClose. That's only useful for users who open badger read-only and expect high-performance queries. We never do that. 2. Default Truncate to true. The user can still override this but, 99% of the time, this is what the user wants. We already set this in go-ipfs but setting it here gives libp2p users sane defaults. fixes #42
ghost
assigned 
|
The Trucate, IIRC, was a bug in badger. We would have to verify on Windows. |
So, truncate just means "throw away any data we may have been writing when we crashed". Given that we write everything synchronously and wait for writes to complete, we decided to enable truncate by default everywhere. |
|
I think it was fix for: dgraph-io/badger#476 |
|
That windows check was, yes. However, we still had a problem on Linux (when killing the daemon). That's why we've enabled truncate by default. |
magik6k
approved these changes
Mar 8, 2019
datastore.go
Outdated
| @@ -63,6 +69,8 @@ func NewDatastore(path string, options *Options) (*Datastore, error) { | |||
| gcDiscardRatio = options.gcDiscardRatio | |||
| } | |||
|
|
|||
| // TODO: remove this? We should let the user choose what they want to | |||
| // do. | |||
We now default to true everywhere.
Stebalien
force-pushed
the
fix/tweak-options
branch
from
9be9ce3
to
3310270
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #42