Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default cidv1 to base32 #13

Merged
merged 3 commits into from
May 13, 2019
Merged

default cidv1 to base32 #13

merged 3 commits into from
May 13, 2019

Conversation

Stebalien
Copy link
Member

No description provided.

@ghost ghost assigned Stebalien May 6, 2019
@ghost ghost added the status/in-progress In progress label May 6, 2019
@magik6k magik6k self-requested a review May 6, 2019 17:30
@magik6k
Copy link
Member

magik6k commented May 6, 2019

CI complains about gofmt

magik6k
magik6k approved these changes May 6, 2019
View reviewed changes
Copy link
Member

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(We might want to add a test case for this (I'm sort of surprised that one doesn't exist))

@Stebalien Stebalien mentioned this pull request May 7, 2019
Merged
3 tasks
@Stebalien Stebalien merged commit 8d1606f into master May 13, 2019
@Stebalien Stebalien deleted the feat/cidv1-default-base32 branch May 13, 2019 17:54
@Stebalien Stebalien removed the status/in-progress In progress label May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

Assignees

@Stebalien Stebalien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stebalien @magik6k