This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
reduce provide workers to 6 #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Stebalien
force-pushed
the
fix/reduce-provide-workers
branch
from
4806f0c
to
c95de94
Compare
|
This does slow down providing by quite a bit. Unfortunately, we always provide in add-order which means we send out a provider record for the root (the most important block) last. Hopefully ipfs/kubo#5870 will alleviate this. |
|
We probably should give this a test drive on gateways |
|
We should test it on gateway dev node, not the on core infrastructure. EDIT: this is already on the gateways. |
|
Yeah, this is on the gateways and it works fine there (for what the gateways do). |
Stebalien
force-pushed
the
fix/reduce-provide-workers
branch
from
c95de94
to
c14bce7
Compare
|
Will merge after ipfs/kubo#6068. |
This'll back up the queue but take a large load off the DHT.
Stebalien
force-pushed
the
fix/reduce-provide-workers
branch
from
c14bce7
to
130a07c
Compare
15 will _never_ succeed
|
@hannahhoward and/or @michaelavila, could I get a sign-off? I've also increased the provide timeout so this is actually useful. |
|
(given that we've discussed this, I'm going to merge now and we can back out later if there are any objections) |
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
…rkers reduce provide workers to 6 This commit was moved from ipfs/go-bitswap@85e3f43
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This'll back up the queue but take a large load off the DHT.