This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
fix: limit use of custom context type #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goprocess returns a _custom_ context type. Unfortunately, golang has a bunch of magic type assertions to efficiently handle built-in context types but launches a new goroutine when deriving a new context from a custom context type. Otherwise, it has no way to wait on the custom context's channel. This fix just ensures we only ever have one of goroutines per provide worker by deriving a (normal) cancelable context up-front and then using that.
ghost
assigned 
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
fix: limit use of custom context type This commit was moved from ipfs/go-bitswap@6acf56a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goprocess returns a custom context type. Unfortunately, golang has a bunch of magic type assertions to efficiently handle built-in context types but launches a new goroutine when deriving a new context from a custom context type. Otherwise, it has no way to wait on the custom context's channel.
This fix just ensures we only ever have one of goroutines per provide worker by deriving a (normal) cancelable context up-front and then using that.