This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
fix: avoid taking accessing the peerQueues without taking the lock #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Or, really, just avoid accessing it. We don't need it. This caused a concurrent map access panic under load.
Stebalien
commented
Jun 10, 2020
| @@ -210,9 +210,6 @@ func (pm *PeerManager) RegisterSession(p peer.ID, s Session) bool { | |||
| pm.peerSessions[p] = make(map[uint64]struct{}) | |||
| } | |||
| pm.peerSessions[p][s.ID()] = struct{}{} | |||
|
|
|||
| _, ok := pm.peerQueues[p] | |||
There was a problem hiding this comment.
We need to take the pm.pqLk before accessing this.
|
@dirkmc this should be good but could you double check tomorrow? |
|
LGTM 👍 I think the bool return value must have been from a previous iteration, but looks like we don't need it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Or, really, just avoid accessing it. We don't need it.
This caused a concurrent map access panic under load.