This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
delay finding providers #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
This feels a bit heavy-handed but it should help. Thoughts @whyrusleeping? |
schomatis
reviewed
Oct 23, 2018
bitswap.go
Outdated
| // NB: Optimization. Assumes that providers of key[0] are likely to | ||
| // be able to provide for all keys. This currently holds true in most | ||
| // every situation. Later, this assumption may not hold as true. | ||
| bs.findKeys <- &blockRequest{ |
There was a problem hiding this comment.
Should we select on ctx.Done() here just in case?
There was a problem hiding this comment.
Good point. I ended up just reworking this patch to move sending the findProvs request to the main select. This also means we can abort this if we end up getting the block before the send completes (should help under heavy load).
It's expensive and causes quite a bit of dialing. Let's give bitswap a second to work it's magic before we try this. fixes #16
Stebalien
force-pushed
the
fix/delay-find-providers
branch
from
4ac28bc
to
93de01c
Compare
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
delay finding providers This commit was moved from ipfs/go-bitswap@a2ce7a2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's expensive and causes quite a bit of dialing. Let's give bitswap a second to work it's magic before we try this.
fixes #16
work towards fixing ipfs/kubo#5613