feat: add fs-repo-12-to-13 #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Jorropo
force-pushed
the
12-to-13
branch
2 times, most recently
from
126afe1
to
bbdb8bd
Compare
This needs tests.
This was referenced Dec 8, 2022
Closed
|
Merged config cleanup migrations into this PR, and included unit test for them + updated this issue with remaining tasks. |
This removes the need for running all legacy migrations every time `make test` or `make build` is executed. "Archived" migrations are added to ignored-migrations and that will ignore them during the build. I also removed iptb because it is used only by ignored migrations, and not having to resolve its dependency issues saves us days of useless work.
Jorropo
commented
Dec 9, 2022
Jorropo
commented
Dec 12, 2022
Jorropo
added a commit
to ipfs/kubo
that referenced
this pull request
Dec 12, 2022
This require to update this cid https://github.com/ipfs/kubo/blob/70e604ff9999752a2773772b6dd14db048d28759/repo/fsrepo/migrations/fetcher.go#L14 once ipfs/fs-repo-migrations#162 is merged and released.
Jorropo
added a commit
to ipfs/kubo
that referenced
this pull request
Dec 12, 2022
This require to update this cid https://github.com/ipfs/kubo/blob/70e604ff9999752a2773772b6dd14db048d28759/repo/fsrepo/migrations/fetcher.go#L14 once ipfs/fs-repo-migrations#162 is merged and released. Fixes #9292
ajnavarro
reviewed
Dec 12, 2022
| @@ -0,0 +1,59 @@ | |||
| // Package atomicfile provides the ability to write a file with an eventual | |||
There was a problem hiding this comment.
Should this file be on tools package?
There was a problem hiding this comment.
Probably, this doesn't need to be done now given that would be function-less code change.
It would help making future migrations cleaner.
ajnavarro
suggested changes
Dec 12, 2022
fs-repo-12-to-13/vendor/github.com/ipfs/fs-repo-migrations/tools/LICENSE
Show resolved
Hide resolved
Keeping user config intact when any of relevant fields was customized
Jorropo
added a commit
to ipfs/kubo
that referenced
this pull request
Dec 12, 2022
This require to update this cid https://github.com/ipfs/kubo/blob/70e604ff9999752a2773772b6dd14db048d28759/repo/fsrepo/migrations/fetcher.go#L14 once ipfs/fs-repo-migrations#162 is merged and released. Fixes #9292
Jorropo
commented
Dec 12, 2022
Jorropo
added a commit
to ipfs/kubo
that referenced
this pull request
Dec 12, 2022
This require to update this cid https://github.com/ipfs/kubo/blob/70e604ff9999752a2773772b6dd14db048d28759/repo/fsrepo/migrations/fetcher.go#L14 once ipfs/fs-repo-migrations#162 is merged and released. Fixes #9292
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs
config_test.go