generated from ipfs/ipfs-repository-template
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add protocol and address filtering to delegated routing api #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #678 +/- ##
==========================================
- Coverage 60.36% 60.30% -0.07%
==========================================
Files 243 243
Lines 30953 31004 +51
==========================================
+ Hits 18684 18696 +12
- Misses 10612 10641 +29
- Partials 1657 1667 +10
|
This was referenced Oct 1, 2024
gammazero
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
gammazero
approved these changes
Oct 1, 2024
3 tasks
wenyue
pushed a commit
to wenyue/boxo
that referenced
this pull request
Oct 17, 2024
…fs#678) * feat: add filtering on client * refactor: abstract add filters to url function * feat: add client filtering to FindPeers * test: test filtering in findPeers --------- Co-authored-by: Daniel N <[email protected]> Co-authored-by: gammazero <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR
Notes
WithDisabledLocalFiltering