Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

routing/http: return PeerRecord for FindPeers #490

Merged
merged 4 commits into from
Oct 17, 2023

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Oct 17, 2023

/routing/v1/peers always returns peer schema conforming objects: https://specs.ipfs.tech/routing/http-routing-v1/#response-body-0.

This makes it easier for the consumers of the library.

@hacdias hacdias requested a review from a team as a code owner October 17, 2023 09:26
@hacdias hacdias changed the title feat!: return PeerRecord for FindPeers routing/http: return PeerRecord for FindPeers Oct 17, 2023
@hacdias hacdias self-assigned this Oct 17, 2023
@hacdias hacdias force-pushed the routing-v1-stronger-type-findpeers branch from 76799c3 to 7353959 Compare October 17, 2023 09:30
@hacdias hacdias requested a review from Jorropo October 17, 2023 09:30
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #490 (256374c) into main (aa6fa14) will decrease coverage by 0.12%.
The diff coverage is 67.69%.

❗ Current head 256374c differs from pull request most recent head 5b2fc58. Consider uploading reports for the commit 5b2fc58 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #490      +/-   ##
==========================================
- Coverage   65.77%   65.66%   -0.12%     
==========================================
  Files         207      207              
  Lines       25130    25167      +37     
==========================================
- Hits        16529    16525       -4     
- Misses       7140     7171      +31     
- Partials     1461     1471      +10     
Files Coverage Δ
routing/http/client/client.go 74.59% <100.00%> (ø)
routing/http/server/server.go 67.45% <100.00%> (ø)
routing/http/types/json/responses.go 45.45% <ø> (ø)
routing/http/contentrouter/contentrouter.go 49.13% <71.42%> (+1.04%) ⬆️
routing/http/types/ndjson/records.go 55.10% <57.89%> (+1.76%) ⬆️
examples/routing/delegated-routing-client/main.go 54.38% <62.06%> (+2.83%) ⬆️

... and 14 files with indirect coverage changes

routing/http/client/client.go Show resolved Hide resolved
routing/http/client/client.go Outdated Show resolved Hide resolved
@hacdias hacdias force-pushed the routing-v1-stronger-type-findpeers branch from 256374c to 5b2fc58 Compare October 17, 2023 16:29
@hacdias hacdias enabled auto-merge (squash) October 17, 2023 16:30
@hacdias hacdias merged commit 0a566c9 into main Oct 17, 2023
11 checks passed
@hacdias hacdias deleted the routing-v1-stronger-type-findpeers branch October 17, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants