ipld/unixfs/hamt: catch panic in walkChildren #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #393 +/- ##
==========================================
+ Coverage 60.18% 60.20% +0.01%
==========================================
Files 241 241
Lines 30707 30712 +5
==========================================
+ Hits 18482 18490 +8
+ Misses 10574 10569 -5
- Partials 1651 1653 +2
|
Jorropo
force-pushed
the
fix/hamt-panic-in-unixfs
branch
from
2e58e9d
to
96312d1
Compare
Jorropo
force-pushed
the
fix/hamt-panic-in-unixfs
branch
from
96312d1
to
ed0a5c7
Compare
|
NVM this does not fix any issues, it prints debug info when that happen, I don't see why printf debugs should be commited ? |
gammazero
approved these changes
Sep 19, 2024
|
@lidel Even though the problem should not happen, do we still want this change in case there are any existing HAMTs that would cause the panic? If not, then please close this PR. |
gammazero
added
the
need/maintainers-input
wenyue
pushed a commit
to wenyue/boxo
that referenced
this pull request
Oct 17, 2024
* ipld/unixfs/hamt: catch panic in walkChildren * Add test for nil link and shard * rename test * Update CHANGELOG.md --------- Co-authored-by: Lucas Molas <[email protected]> Co-authored-by: Andrew Gillis <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From ipfs/go-unixfs#123