Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clean deps and more #677

Merged
merged 1 commit into from
Nov 19, 2020
Merged

fix: clean deps and more #677

merged 1 commit into from
Nov 19, 2020

Conversation

hugomrdias
Copy link
Member

  • remove error-handler, our yargs fail handler is better
  • remove rimraf
  • remove pify
  • update all the deps except webpack

vasco-santos
vasco-santos approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

achingbrain
achingbrain approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is premove better than rimraf? Just smaller?

@hugomrdias
Copy link
Member Author

Why is premove better than rimraf? Just smaller?

Smaller, up to date with new node features and some protections to avoid deleting c:\

@hugomrdias hugomrdias merged commit ac2a3f7 into master Nov 19, 2020
@hugomrdias hugomrdias deleted the feat/clean-deps branch November 19, 2020 10:06
@achingbrain
Copy link
Member

I think this has done something bad to electron - tests are failing in ipfs-utils and ipfs with aegir@29 with similar errors but only on Electron, which I don't think CI is runs on for this repo since it switched to GH actions.

I assume it's this PR, the others in v29 seem benign.

@hugomrdias
Copy link
Member Author

lets revert to electron 10 here, do you want me to do it ?

@achingbrain achingbrain mentioned this pull request Nov 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasco-santos vasco-santos vasco-santos approved these changes

@achingbrain achingbrain achingbrain approved these changes

@Gozala Gozala Gozala approved these changes

@jacobheun jacobheun Awaiting requested review from jacobheun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hugomrdias @achingbrain @Gozala @vasco-santos