Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not include babel-polyfill in ES5 CDN bundles #36

Closed
claus opened this issue Aug 1, 2016 · 2 comments
Closed

Do not include babel-polyfill in ES5 CDN bundles #36

claus opened this issue Aug 1, 2016 · 2 comments
Assignees
@dignifiedquire
Labels
help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws)

Comments

@claus
Copy link

claus commented Aug 1, 2016

Bundling babel-polyfill with libs is discouraged by Babel devs, see https://babeljs.io/docs/usage/polyfill/. The Babel polyfill can only run once in the browser, it throws the second time it runs and pulls everything else down with it.

Suggestions:
@dignifiedquire dignifiedquire added kind/bug A bug in existing code (including security flaws) help wanted Seeking public contribution on this issue milestone 2 labels Aug 1, 2016
dignifiedquire added a commit that referenced this issue Aug 4, 2016
@dignifiedquire
feat: do not depend on babel-polyfill
db11d56 
Closes #36

BREAKING CHANGE:

This can break browser builds and tests and needs to be tested
carefully when upgrading.
@dignifiedquire dignifiedquire mentioned this issue Aug 4, 2016
Merged
@dignifiedquire dignifiedquire self-assigned this Aug 4, 2016
@dignifiedquire dignifiedquire removed the status/in-progress In progress label Aug 19, 2016
@dignifiedquire dignifiedquire mentioned this issue Sep 5, 2016
Closed
@dignifiedquire dignifiedquire reopened this Sep 6, 2016
@dignifiedquire
Copy link
Member

Reverted, as we first need to figure out how to solve this in our ecosystem

@dignifiedquire dignifiedquire removed their assignment Sep 8, 2016
@lidel lidel mentioned this issue Oct 1, 2016
Closed
@dignifiedquire
Copy link
Member

Fixed in 9.0.0 as we don't use babel anymore

@lidel lidel mentioned this issue Oct 31, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dignifiedquire dignifiedquire

Labels
help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@claus @dignifiedquire @daviddias