Skip to content

Commit

Permalink
fix: add detective-cjs dependency to fix depcheck command (#903)
Browse files Browse the repository at this point in the history
Fixes the recent breakage with dep checking - looks like they stopped bundling the `detective` module, so I've switched it for `detective-cjs` since that's what's now used in the dependency-check module tests.
  • Loading branch information
achingbrain authored Nov 5, 2021
1 parent 27774d1 commit 48ed6b5
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@
"conventional-github-releaser": "^3.1.5",
"copyfiles": "^2.4.1",
"cors": "^2.8.5",
"dependency-check": "^5.0.0-1",
"dependency-check": "^5.0.0-2",
"detective-cjs": "^3.1.1",
"detective-es6": "^2.2.0",
"electron-mocha": "^10.0.0",
"env-paths": "^2.2.1",
Expand Down
2 changes: 1 addition & 1 deletion src/dependency-check.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ const check = (argv, execaOptions) => {
if (pkg.type === 'module') {
// use detective-es6 for js, regular detective for cjs
args.push(
'--extensions', 'cjs:detective',
'--extensions', 'cjs:detective-cjs',
'--extensions', 'js:detective-es6'
)
}
Expand Down

0 comments on commit 48ed6b5

Please sign in to comment.