Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially cleaned up the APITest. #217

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

odisseus
Copy link
Contributor

@odisseus odisseus commented Feb 28, 2023

  • Replaced Arrays.aslist with Collections.singletonList whenever possible, because passing a single array to the former method can be confusing;
  • Fixed an error in the recursiveRefs test, where one of the test outcomes wasn't actually checked;
  • Suppressed the compiler warnings about:
    • unparameterized generic types, because this test uses the API methods that just return Map without type parameters;
    • unused variables because there is a lot of them, and fixing this right now would require too many changes;
  • Replaced assertTrue with more specific assertions for better failure messages;
  • Added static imports for assertEquals etc. to reduce the clutter a little bit;
  • Added @Ignore annotations to the disabled test cases so that they are visible in the test report.

Copy link
Collaborator

@ianopolous ianopolous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you.

@ianopolous ianopolous merged commit 07395a0 into ipfs-shipyard:master Feb 28, 2023
@odisseus odisseus deleted the tests-cleanup branch March 17, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants