Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mutable tests with new spec #6

Merged
merged 15 commits into from
Jun 26, 2022
Merged

Update mutable tests with new spec #6

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
a452899
Update README and fix existing tests
makew0rld Apr 27, 2022
1c2b23b
Add remaining mutable tests
makew0rld Apr 27, 2022
21eb5ec
Update for spec changes (IPNS key API)
makew0rld May 11, 2022
a888639
Update for spec changes and errant URLs. Also .url won\
makew0rld May 11, 2022
03f9438
Fix key GET test
makew0rld May 11, 2022
b228994
Fixes for mutable tests
RangerMauve May 12, 2022
b13756c
Undo IPNS key change
makew0rld May 13, 2022
f4a15fc
Use URL to check hostname on ipns redirect
RangerMauve May 13, 2022
d31cd84
Fix up tests
makew0rld May 13, 2022
2c4f444
Fix last failing mutable test, all pass now
makew0rld May 13, 2022
0b72465
Merge pull request #1 from AgregoreWeb/daemon-spec
RangerMauve May 16, 2022
c60d8d3
Fix merge errors
RangerMauve May 17, 2022
097fe35
Manually specify API to use so that Agregore's built in node can be c…
RangerMauve Jun 4, 2022
1ec3ca1
Merge branch 'daemon-spec' into default
RangerMauve Jun 10, 2022
9bd62d4
Use proper format strings
RangerMauve Jun 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 18 additions & 12 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,19 +31,25 @@ Progress: https://github.com/ipfs/community/discussions/573
- [x] Render empty directories
- [x] Resolve `index.html` in a path
- `mutable.html` Tests (experimental, some things subject to change)
- [x] JS `fetch('ipfs://CID/example.txt', {method: 'POST'})`
- [x] JS `fetch('ipns://CID/', {method: 'POST'})`
- [x] JS `fetch('ipns://CID/example.txt', {method: 'POST'})`
- [x] JS `fetch('ipfs://CID/', {method: 'POST', body: new FormData})`
- [x] JS `fetch('ipfs://CID/example.txt', {method: 'DELETE'})`
- [x] JS `fetch('ipns://CID/example.txt', {method: 'DELETE'})`
- [x] JS `fetch('ipfs://<CID>/example.txt', {method: 'PUT'})`
- [x] JS `fetch('ipfs://<CID>/', {method: 'PUT', body: new FormData})`
- [x] JS `fetch('ipfs://<CID>/example.txt', {method: 'DELETE'})`
- [x] JS `fetch('ipns://<key>', {method: 'POST', body: <CID>})`
- [x] JS `fetch('ipns://<key>/example.txt', {method: 'POST', body: <CID>})`
Comment on lines +37 to +38
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 sending CID in the body feels weird, but I can't put my finger on why 😅

I was thinking that maybe it is squatting too much, what if one wants to do IPNS in userland, maintain keys on their own, create, sign record in JS, and then send it to ipns:// only for publishing? I believe we should make sure a primitive for doing it exists.

I guess that could be represented as POST with Content-Type: application/vnd.ipfs.ipns.record ?

- [x] JS `fetch('ipns://<key>', {method: 'PUT', body: file})`
- [x] JS `fetch('ipns://<key>/example', {method: 'PUT', body: file})`
- [x] JS `fetch('ipns://<key>', {method: 'PUT', body: formdata})`
- [x] JS `fetch('ipns://<key>/example', {method: 'PUT', body: formdata})`
- [x] JS `fetch('ipns://<key>/example.txt', {method: 'DELETE'})`
- [x] JS `fetch('ipns://localhost?key=<name>', {method: 'GET})`
- [x] JS `fetch('ipns://localhost?key=<name>', {method: 'DELETE})`
- `dag.html` Tests (experimental, some things subject to change)
- [x] GET `ipfs://CID/?format=CAR`
- [x] GET `ipfs://CID/?format=block`
- [x] GET `ipfs://CID/?format=dag-json`
- [x] GET `ipfs://CID/?format=dag-cbor`
- [x] POST `Content-Type: application/json` `?format=dag-cbor` & GET `?format=dag-cbor`
- [x] POST over existing CID to add to graph
- [x] GET `ipfs://<CID>/?format=CAR`
- [x] GET `ipfs://<CID>/?format=block`
RangerMauve marked this conversation as resolved.
Show resolved Hide resolved
- [x] GET `ipfs://<CID>/?format=dag-json`
- [x] GET `ipfs://<CID>/?format=dag-cbor`
- [x] POST `Content-Type: application/json` `?format=dag-cbor` & GET `?format=dag-cbor`
- [x] POST over existing CID to add to graph

## Screenshots:

Expand Down
Loading