-
Notifications
You must be signed in to change notification settings - Fork 864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tray Icon problems on Linux #1153
Comments
Hm, not a fan of this solution. Tray icons are an important feature. The desktops missing them are just deficient, intentionally or not, and regardless of their design philosophy. A better solution would be to open a window when clicking on the application's launcher. That way, it now gains a behavior that's intuitive (clicking on a launcher generally launches the app) and it fixes the tray icon problem rather than creating a missing tray icon problem for other Linux users. |
As a first step, we can have desktop open the webui window on launch as suggested. I'm not clear on how we can show the user that the app is still running if they close the window... what happens on others apps that are long running on desktops that dont have task tray icons? |
I don't know any long-running apps without tray icons except for command-line apps, but those don't even have desktop icons in the first place. For long-running apps with a tray icon on systems without a system tray, however, I've noticed a pattern.
None of them closes on close. They minimize on minimize and go to system tray on close. One problem that may arise is that options in the tray app will be hidden. This can be fixed by having them accessible from inside the app as well. |
I absolutely agree, but we should do that only on Linux perhaps. And even there some issues might arise... What about those users who have IPFS Desktop setup to start up automatically when they turn on the computer? I doubt anyone wants a window to be open in those cases. I can investigate to see if there's any way to know if the app is being launched by a startup mechanism or not. |
I like your idea about doing that on only Linux @hacdias, but perhaps we should be even more specific. On the default KDE layout, for example, it has a system tray, and it works perfectly, however, on Gnome, there seems to be no tray whatsoever.
|
Note to self: Tray support on modern linux DE is severely broken. Seems that old Tray support was replaced with
|
@chromium did and Electron v8 took it as a given thing. |
See my solution: |
@dotenorio I am afraid the code you linked is a fix for other issue (electron/electron#22443). I don't believe it solves the mess of Electron 8 switching to |
For testing purposes, I was able to get tray icon back on |
@hacdias the screenshot of Lungo app you posted in the other issue inspired me to come up with a potential workaround for Linux for next 10 years (until everyone switch to Idea: Rationale:
|
Thanks for heads up in the original issue @vladimiry!
Let's reopen this and track progress in electron/electron#23674 – if Electron indeed restores old tray support, that would be great news for our Linux users. |
electron/electron#23674 got merged and backported to 8.x: electron/electron#23674 (comment) It seems to be the lesser evil that is here to stay for a few more years. @rafaelramalho19 I believe upgrading to electron v8.4.1 should include the above "fix". Sooner we switch, the sooner we identify any UX regressions caused by it on various Linuxes. |
This comment has been minimized.
This comment has been minimized.
Heads up: we are planning to switch to Electron 9 in the next release, and it will include change described in #1153 (comment) |
@bertrandfalguiere thank you for testing v0.13.0 with Electron 9.x across different distros in #1661 ❤️ |
@lidel The tray icon behave nominally now on my system with v0.13.0 :). |
@bertrandfalguiere that is enough, thank you! I was mostly worried about Ubuntu, as historically they used custom stuff and hid tray indicators. Seems that Electron 9.x correctly supports whatever Ubuntu uses these days, so all good 👍 This issue can be closed when v0.13 ships (#1661) |
I believe this should be fixed in v0.13, but please reopen if you experience any tray problems (include info about your distro and DE/WM/tray setup) |
There really should be a way to use IPFS Desktop without any tray icon. For example, GNOME by default does not include any appindicator support, and as a user that's not something I'd change. |
I'd just like to add, that while I do very much agree with @teohhanhui , many other native linux apps ported from windows (such as zoom) make the same tray icon assumptions. I feel that Gnome shouldn't have removed that appindicator support, but now that they have, I wouldn't imagine that all users would want to go through the process of setting it up. (On the other hand, most other DE's do include appindicator support) |
GNOME did it for good reason: https://blogs.gnome.org/aday/2017/08/31/status-icons-and-gnome/ Anyway, the reality is that it's highly unlikely for appindicator or similar to be supported by default: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/1014 So app developers should provide a way to use the app without tray icon. It's not that hard. Many other apps have done it. |
@teohhanhui do you have examples of some apps that do it "correctly"? Would be really useful to study their behavior and implement something similar. |
Discord, for example. Use of the tray icon should be entirely optional. Relevant items from the tray menu can be duplicated in an in-app menu. But even Steam's behaviour (close never exits; the user has to explicitly select "Exit" from the in-app menu), while not ideal, is still better than what IPFS Desktop is doing now. |
Just to make sure, @lidel, are you asking for this list again?
|
For example in https://github.com/vladimiry/ElectronMail when it's already started and you launch its binary/shortcut again it will open/activate the window of already executed app instance. Some users bind the binary execution to a hotkey and so they use the hotkey to unhide the app from the tray (from the hidden state if there is no tray).
Pretty regular behavior on Windows systems. It's good though if there is an option to make the window close action close the app.
This is how it's done in ElectronMail. |
So, there are quite a few issues with people complaining they can't access the UI of IPFS Desktop on Linux. All of them are caused by the same reason: tray icons are being deprecated from many desktop environments and Electron has not yet worked out on a solution, nor it seems to be happening soon.This affects all kinds of packages.
One possible way for us to circumvent this for now is to open the main Web UI window on Linux on startup. However, that will still leave the options of exiting desktop and other options provided by the menu behind.
I'm opening this in hope to gather feedback on how to create an workaround around this.
Please note that Linux support is experimental nonetheless.
The text was updated successfully, but these errors were encountered: