feat: adding base countly metric functionality #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
SgtPooki
requested changes
Dec 13, 2022
| @@ -0,0 +1,29 @@ | |||
| # See https://help.github.com/articles/ignoring-files/ for more about ignoring files. | |||
There was a problem hiding this comment.
i'd highly recommend getting familiar with gitignore.io. https://www.toptal.com/developers/gitignore/api/visualstudiocode,macos,windows,linux,node is a great default for our projects
src/components/Warning/Warning.tsx
Outdated
Comment on lines
20
to
29
| { | ||
| showMetricInfoLink && | ||
| <div className="metric-info-link-wrapper"> | ||
| See | ||
| <a className="metrics-warning-link" href="https://support.count.ly/hc/en-us/articles/360037441932-Web-analytics-JavaScript-#features-for-consent" target="_blank" rel="noreferrer"> | ||
| {`Countly's group_features`} | ||
| </a> | ||
| for more information. | ||
| </div> | ||
| } |
There was a problem hiding this comment.
this could be a dumb component to clean this code up
|
Hey @SgtPooki @djmcquillan we should publish this as an ESM, so we can use this as anywhere we load UI like we use geoip https://playcode.io/991829 It's much more convenient to integrate. |
and cleanup code see Countly/countly-sdk-web#337
SgtPooki
approved these changes
Dec 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes ipfs/ipfs-gui#129