-
Notifications
You must be signed in to change notification settings - Fork 128
Conversation
This is great! 👍 :) Let's put it under docs though - the top level navigation is already quite crowded. |
@victorbjelkholm sorry it took me some time to get to this. I don’t have commit access here, so I wrote up some grammar and basic language cleanup here: #255 I tried to keep the general tone and structure the same. I’ll add some inline comments on this PR, too. |
- Clean up some grammar - Try to use more active voice and calls to action - Add some links - Remove "wet dream" language
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add anything here about regular organizing calls (e.g. the IPFS all-hands or the JS-IPFS standup)?
content/contribute/index.md
Outdated
|
||
Currently, there is no fulltime designers working with IPFS and it's sister-projects. | ||
Although it would be nice to have, we still have many smaller pieces that can be | ||
contributed by you as a outsider! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be linking to any of these projects here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Less is more :) Safe set of design-related repos:
- https://github.com/ipfs-shipyard/pm-ipfs-gui
- https://github.com/ipfs-shipyard/ipfs-ui-style-guide (it will link / reference other repos)
Apps that are under "gui" umbrella:
content/contribute/index.md
Outdated
|
||
Protocol Labs is in the ground and bottom a research lab, where YOUR idea can | ||
become real, if it can have a real impact on the world. If you're interested in | ||
contributing to the research, please reach out to [email protected] or [email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these be mailto:
links, or are we trying to avoid that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, mailto:
sounds good, think it was just because of laziness I didn't add it. Can't find a reason why we would avoid it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, can we make Hugo do that automatically? (Do we want to?)
content/contribute/index.md
Outdated
As we're continously improving IPFS everyday, mistakes can happen and we release | ||
something that could work much better or simply doesn't work. If you like to | ||
dig into edge-cases or writing testing scenarios, getting dirty with all our | ||
testing infrastructure would be a wet dream for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I re-worded this in my PR, but we should avoid this kind of language. It’s offensive and off-putting to many people.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the feedback, will keep in mind for the future.
Tighten up language on new contribute page
You should have write access now so you can make changes directly in the branch this PR is based on.
Yeah, that feels like essential information for contributors. Maybe better to guide them to the calendar rather than hardcoding times/meetings and such, not sure? |
Just wanted to note that I’ve added this content to the new docs site at ipfs-inactive/docs#68. Not sure if that means we should close this. |
This page & content is incorporated in the new docs site at |
I’m closing this since it’s been added to the new docs site and there was no feedback here for a month. Please comment if it should be re-opened! |
This commit adds a new page to the website where information about how people can contribute to IPFS. It's a WIP at this point and the text is a mess but contains most points I could come up with at least. Would appreciate people to help out with the text and add any missing sections.
Published a preview here: https://ipfs.io/ipfs/QmTx5PUChDwdqXSfVS9CtNZqztk2Yvuoo161ScnQVwwSGQ/contribute/
Thoughts?