Skip to content
This repository has been archived by the owner on Jul 5, 2021. It is now read-only.

Generate API docs directly from go-ipfs #156

Merged
1 commit merged into from
Nov 12, 2016
Merged

Generate API docs directly from go-ipfs #156

1 commit merged into from
Nov 12, 2016

Conversation

hsanjuan
Copy link
Member

@hsanjuan hsanjuan commented Nov 3, 2016

Since Apiary does not really adapt to our needs and it is one more place
that needed manual maintenance, it is just better to automatically generate
documentation from go-ipfs and have this implementation as the source
of truth. This commit replaces the API reference page with a new
autogenerated one.

This comes out of efforts around:

Some screenshots:

screenshot_2016-11-03_10-29-43


screenshot_2016-11-03_10-30-06


screenshot_2016-11-03_10-30-21


screenshot_2016-11-03_10-30-57

Since Apiary does not really adapt to our needs and it is one more place
that needed manual maintenance, it is just better to automatically generate
documentation from go-ipfs and have this implementation as the source
of truth. This commit replaces the API reference page with a new
autogenerated one.
@dignifiedquire
Copy link
Contributor

@hsanjuan cool, how did you generate this?

@hsanjuan
Copy link
Member Author

hsanjuan commented Nov 7, 2016

@dignifiedquire https://github.com/hsanjuan/ipfs-http-api-docs . Sorry about the lack of readme/docs, waiting for feedback to see if it's actually worth including it in go-ipfs or can leave as a separate repo.

@hsanjuan
Copy link
Member Author

hsanjuan commented Nov 8, 2016

So what's the process to merge? Do I need someones approval? Is there any more feedback?

@RichardLitt
Copy link
Contributor

I like this very much. I think this is fine as a separate repo, as we try to make go-ipfs as small as possible (right, @whyrusleeping?).

I think this is good to merge. @lgierth should be able to do that.

I am trying to get the site working so that I can see how this looks on the site, but am unable to do so at the moment (see #140). There's no greater process to merge: I believe that my sign off and @lgierth's merge should be enough to push it out.

@RichardLitt
Copy link
Contributor

Nevermind, got it working using venv. This looks great.

I still would like a specification that we can refer to. But I may be behind on that conversation.

@hsanjuan
Copy link
Member Author

@RichardLitt as weird as it sounds, the go-code is the de-facto spec for this (http api).

@RichardLitt
Copy link
Contributor

@hsanjuan That works. Just want to make sure that that is explicit, because that was not clear from the other http-api docs. :)

@ghost
Copy link

ghost commented Nov 12, 2016

This LGTM 👍

Need to move hsanjuan/ipfs-http-api-docs to the ipfs organization, so that the link in line 20 works

@ghost ghost merged commit d25743f into master Nov 12, 2016
@ghost ghost deleted the feat/api-reference branch November 12, 2016 04:27
@ghost ghost removed the in progress label Nov 12, 2016
@hsanjuan
Copy link
Member Author

Thanks @lgierth

Need to move hsanjuan/ipfs-http-api-docs to the ipfs organization, so that the link in line 20 works

Yes, I'll do it today and will ping here when it's ready

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants