This repository has been archived by the owner on Aug 12, 2020. It is now read-only.
Use passed CID version option when writing to storage #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 8, 2017
daviddias
reviewed
Sep 8, 2017
|
|
||
| if (options.cidVersion === 1) { | ||
| cid = cid.toV1() | ||
| } |
daviddias
approved these changes
Sep 8, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary because:
If I put an object using a CIDv0 with the ipld resolver I have to retrieve it using a CIDv0, I can’t use CIDv1, even if the multihash and the codec are the same.
This is because the key for the data in the repo is derived from
CID.bufferSee https://github.com/ipld/js-cid/blob/master/src/index.js#L115-L128
And https://github.com/ipfs/js-ipfs-repo/blob/master/src/blockstore.js#L29-L31