Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

fix: updates ipld-dag-pb dep to version without .cid properties #889

Merged
merged 1 commit into from
Nov 13, 2018

Conversation

achingbrain
Copy link
Collaborator

Follows on from ipld/js-ipld-dag-pb#99 and updates this module to not rely on DAGNodes having knowledge of their CIDs.

@ghost ghost assigned achingbrain Nov 8, 2018
@ghost ghost added the in progress label Nov 8, 2018
@achingbrain
Copy link
Collaborator Author

The ping and pubsub tests will be the end of me.

Follows on from ipld/js-ipld-dag-pb#99 and
updates this module to not rely on DAGNodes having knowledge of
their CIDs.
@achingbrain achingbrain force-pushed the update-dag-pb-to-not-have-cid-property branch from 64760d3 to c194b3a Compare November 12, 2018 16:12
Copy link
Contributor

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, waiting on CI.

@alanshaw alanshaw merged commit ac30a82 into master Nov 13, 2018
@alanshaw alanshaw deleted the update-dag-pb-to-not-have-cid-property branch November 13, 2018 08:46
@ghost ghost removed the in progress label Nov 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants