Fix 683 #688
Fix 683 #688
Conversation
ghost
assigned 
test/bitswap.spec.js
Outdated
| @@ -9,15 +9,16 @@ chai.use(dirtyChai) | |||
| const IPFSApi = require('../src') | |||
|
|
|||
| const DaemonFactory = require('ipfsd-ctl') | |||
| const df = DaemonFactory.create() | |||
| const df = DaemonFactory.create({remote: true, port: 30003}) | |||
There was a problem hiding this comment.
@dryajov I'm confused. From docs seems that this is the way to spawn remove daemons, however, it seems it didn't use it even once for all the tests. Is there any magic trick? Truth be told, tests are failing and so I suspect this to be it.
There was a problem hiding this comment.
By default, it detects if not running in node, it will assume we're in the browser and use the remote daemon. So, no arguments to create will do what you expect depending on env. This was a specific requirement we discussed during the revamp of ipfsd.
There was a problem hiding this comment.
So no need for explicit remote unless you have to specify the port.
package.json
Outdated
| }, | ||
| "scripts": { | ||
| "test": "aegir test", | ||
| "test:node": "aegir test -t node", | ||
| "test:browser": "aegir test -t browser", | ||
| "test:browser": "node --max-old-space-size=8192 ./node_modules/.bin/aegir test -t browser", |
There was a problem hiding this comment.
Still no luck. Kind of running out of my options here :(
There was a problem hiding this comment.
@vmx @pgte @dignifiedquire any Webpack wisdom to solve this issue? I'm using the latest ipfs/js-ipfsd-ctl#200 and no luck still.
There was a problem hiding this comment.
Actually, spoke too soon, IT RUUUNS :D
|
remaining issues are being handled on #651 |
No description provided.