Merge pull request #130 from Dignifiedquire/log

feat: Fix log/tail for 0.3.9

package.json

@@ -7,6 +7,7 @@
     "merge-stream": "^1.0.0",
     "multiaddr": "^1.0.0",
     "multipart-stream": "^2.0.0",
+    "ndjson": "^1.4.3",
     "qs": "^6.0.0",
     "vinyl": "^1.1.0",
     "vinyl-fs-browser": "^2.1.1-1",

src/index.js

@@ -4,6 +4,7 @@ const multiaddr = require('multiaddr')
 const getConfig = require('./config')
 const getRequestAPI = require('./request-api')
 const Wreck = require('wreck')
+const ndjson = require('ndjson')
 
 exports = module.exports = IpfsAPI
 
@@ -203,7 +204,10 @@ function IpfsAPI (host_or_multiaddr, port) {
 
   self.log = {
     tail (cb) {
-      return requestAPI('log/tail', null, {enc: 'text'}, null, true, cb)
+      requestAPI('log/tail', null, {}, null, false, (err, res) => {
+        if (err) return cb(err)
+        cb(null, res.pipe(ndjson.parse()))
+      })
     }
   }
 

test/tests.js

@@ -619,15 +619,18 @@ describe('IPFS Node.js API wrapper tests', () => {
   })
 
   describe('.log', function () {
-    // TODO news 0.3.9 ndjson stuff
-    it.skip('.log.tail', function (done) {
+    it('.log.tail', function (done) {
+      this.timeout(20000)
+
       apiClients['a'].log.tail((err, res) => {
         if (err) {
           throw err
         }
-
-        console.log('->', res)
-        done()
+        res.once('data', obj => {
+          assert(obj)
+          assert.equal(typeof obj, 'object')
+          done()
+        })
       })
     })
   })