This repository has been archived by the owner on Apr 16, 2020. It is now read-only.
Setting timeout to 1 second #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In go-ipfs when we have to check something after timeout, we usually do polling with interval with some maximum timeout, as js test suits grows waiting might be the slowing factor. I am not saying that this PR should implement something like that but I am suggesting creation of such utility function and latter replacement of straight up waits will polls. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The setTimeout() function in the read-write.js file was set to 200 milliseconds. My tests were failing on a slower maching so I set the timeout to 1 second to give time for the write operation to finish.