This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
test: add missing tests #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
achingbrain
force-pushed
the
add-missing-tests
branch
2 times, most recently
from
3c1dee8
to
7b14147
Compare
Our http tests in `js-IPFS` duplicate a whole bunch of tests from this suite, but they also test some unhappy paths that this suite does not. I've pulled them out of `js-IPFS` as part of ipfs/js-ipfs#2495 and am adding them to the interface tests here.
achingbrain
force-pushed
the
add-missing-tests
branch
from
7b14147
to
fa042d3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our http tests in
js-IPFSduplicate a whole bunch of tests from this suite, but they also test some unhappy paths that this suite does not.I've pulled them out of
js-IPFSas part of ipfs/js-ipfs#2495 and am adding them to the interface tests here.