This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
test: make files.ls results ordering consistent #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
achingbrain
requested review from
alanshaw
and removed request for
travisperson and
victorb
Previously we'd get files in different orders between `files.ls()` and
`files.ls({long: true})` due to a bug in `go-ipfs` (see ipfs/kubo#5181)
Since this has been resolved we can now expect consistent ordering.
achingbrain
force-pushed
the
consistent-ls-list-order
branch
from
c62f36d
to
02ea64c
Compare
achingbrain
changed the title
achingbrain
changed the title
|
This will break the |
alanshaw
approved these changes
Aug 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we'd get files in different orders between
files.ls()andfiles.ls({long: true})due to a bug ingo-ipfs(see ipfs/kubo#5181)Since this has been resolved we can now expect consistent ordering.