This repository has been archived by the owner on Apr 29, 2020. It is now read-only.
Added Group files
#58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Note ipfs/kubo#2423 |
RichardLitt
force-pushed
the
feature/files
branch
from
d883187
to
fb5af11
Compare
|
@diasdavid or @dignifiedquire, want to take a crack at reviewing this? |
RichardLitt
force-pushed
the
feature/files
branch
from
fb5af11
to
e7bb6e9
Compare
|
@RichardLitt what is missing here for the merge? |
|
@diasdavid It needs review. |
Not sure the argument is actually required, if it defaults.
I'm not sure what -l is doing, or why it adds the hashes and they aren't present elsewhere. But here it is.
I was unable to get `parents` to work as expected. I expect it is a CLI parse. cc @whyrusleeping
I may have had too much fun here.
Lots of issues with this one.
RichardLitt
force-pushed
the
feature/files
branch
from
f248a46
to
f6b980a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current issues that should be resolved first:
ipfs files rmrecursive flag doesn't affect output ipfs/kubo#2378