Added Group `dht` #44

RichardLitt · 2016-02-06T23:08:38Z

Noted two main bugs:

- [ ] While verbose is specified in the HTTP API and is used in the HTTP request,
it returns no extra information in the ndjson response.

An invalid or empty key returns the same response as a normal one.

dignifiedquire · 2016-02-17T13:37:13Z

apiary.apib

+
+FindProviders will return a list of peers who are able to provide the value requested.
+
+#### Bugs


Maybe called it Known Bugs

Ideally, these should be solved before this is actually merged.

then ignore me :)

Any issue on go-ipfs to track this bug?

Not a real bug.

dignifiedquire · 2016-02-19T13:13:45Z

Needs rebase

RichardLitt · 2016-02-19T13:40:28Z

I accidentally rebased on top of #42. :|

daviddias · 2016-02-19T20:24:53Z

While verbose is specified in the HTTP API and is used in the HTTP request, it returns no extra information in the ndjson response.

Seems like something that was deprecated

An invalid or empty key returns the same response as a normal one.

In which case:

    ipfs dht query <peerID>...    - Run a 'findClosestPeers' query through the DHT.
    ipfs dht findprovs <key>...   - Run a 'FindProviders' query through the DHT.
    ipfs dht findpeer <peerID>... - Run a 'FindPeer' query through the DHT.
    ipfs dht get <key>...         - Run a 'GetValue' query through the DHT.
    ipfs dht put <key> <value>    - Run a 'PutValue' query through the DHT.

RichardLitt · 2016-03-03T15:13:12Z

@whyrusleeping I'm looking at the code, and I honestly can't see how the ipfs dht findprovs <key> is anything similar to what is returned by the API. Moreover, verbose seems to be only used in conditionals in the Gocode to print stuff using Fprintf; am I right in thinking that this isn't caught by the marshaller // converted into JSON?

RichardLitt · 2016-03-09T19:30:16Z

@RichardLitt Marshallers are client side. Remove verbose.

RichardLitt · 2016-04-13T14:39:56Z

Should be good to go. Not sure if this is how these are actually supposed to look, but seems to work fine.

Noted two main bugs: - [ ] While `verbose` is specified in the HTTP API and is used in the HTTP request, it returns no extra information in the ndjson response. - [ ] An invalid or empty key returns the same response as a normal one.

daviddias · 2016-04-19T14:51:42Z

apiary.apib


-## findprovs
+This command can't be called directly.


What does this exactly mean? Example?

I mean you can't call curl -i "http://localhost:5001/api/v0/dht". It makes sense with context, and I've used this notation elsewhere. I can change it to be more blatant?

Specifically, if you try:

🐕 curl -i "http://localhost:5001/api/v0/dht" HTTP/1.1 400 Bad Request Access-Control-Allow-Headers: X-Stream-Output, X-Chunked-Output, X-Content-Length Access-Control-Expose-Headers: X-Stream-Output, X-Chunked-Output, X-Content-Length Content-Type: application/json Server: go-ipfs/0.4.1-dev Trailer: X-Stream-Error Date: Tue, 19 Apr 2016 14:53:01 GMT Transfer-Encoding: chunked {"Message":"This command can't be called directly. Try one of its subcommands.","Code":1}

Ah, I see. /dht isn't an endpoint, that is ok :)

Yep. Just pointing that out for the user.

daviddias · 2016-04-19T14:53:19Z

apiary.apib

+
+ Response 200
+
+    The response has been truncated to a single ndjson object, as the responses are streamed.


daviddias · 2016-04-19T14:59:12Z

LGTM :)

RichardLitt added the needs review label Feb 6, 2016

dignifiedquire reviewed Feb 17, 2016
View reviewed changes

dignifiedquire mentioned this pull request Feb 17, 2016

Sprint: February 16 (Tuesday) ipfs/team-mgmt#91

Closed

RichardLitt force-pushed the feature/dht branch 2 times, most recently from 1eb2bc7 to 305a651 Compare February 19, 2016 01:30

RichardLitt force-pushed the feature/dht branch from 305a651 to 2f8119c Compare February 19, 2016 13:40

RichardLitt force-pushed the feature/dht branch from 128084c to a42fc75 Compare March 3, 2016 15:05

RichardLitt assigned whyrusleeping Mar 3, 2016

RichardLitt assigned RichardLitt and unassigned whyrusleeping Mar 9, 2016

RichardLitt removed the needs review label Mar 15, 2016

RichardLitt removed their assignment Apr 13, 2016

RichardLitt added the needs review label Apr 13, 2016

RichardLitt assigned daviddias Apr 13, 2016

RichardLitt mentioned this pull request Apr 18, 2016

Sprint: April 6 → April 18 ipfs/team-mgmt#101

Closed

RichardLitt added 5 commits April 19, 2016 10:51

Added Group dht

ea4a992

Noted two main bugs: - [ ] While `verbose` is specified in the HTTP API and is used in the HTTP request, it returns no extra information in the ndjson response. - [ ] An invalid or empty key returns the same response as a normal one.

Update string following ipfs/kubo#2372

88d124b

Removed bugs, cleaned up

5b10d79

Update headers

cda1b60

Added responses entry

52f7631

daviddias reviewed Apr 19, 2016
View reviewed changes

RichardLitt force-pushed the feature/dht branch from 6a8232f to 52f7631 Compare April 19, 2016 14:51

daviddias reviewed Apr 19, 2016
View reviewed changes

apiary.apib

+ Response 200

The response has been truncated to a single ndjson object, as the responses are streamed.

Copy link

Contributor

daviddias Apr 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

daviddias mentioned this pull request Apr 19, 2016

Sprint: April 18 → May 3 ipfs/team-mgmt#104

Closed

daviddias removed the needs review label Apr 19, 2016

RichardLitt merged commit f36b363 into master Apr 19, 2016

RichardLitt deleted the feature/dht branch April 19, 2016 14:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Group `dht` #44

Added Group `dht` #44

RichardLitt commented Feb 6, 2016

dignifiedquire Feb 17, 2016

RichardLitt Feb 18, 2016

dignifiedquire Feb 19, 2016

daviddias Apr 12, 2016

RichardLitt Apr 13, 2016

dignifiedquire commented Feb 19, 2016

RichardLitt commented Feb 19, 2016

daviddias commented Feb 19, 2016

RichardLitt commented Mar 3, 2016

RichardLitt commented Mar 9, 2016

RichardLitt commented Apr 13, 2016

daviddias Apr 19, 2016

RichardLitt Apr 19, 2016

RichardLitt Apr 19, 2016

daviddias Apr 19, 2016

RichardLitt Apr 19, 2016

daviddias Apr 19, 2016

daviddias commented Apr 19, 2016


		FindProviders will return a list of peers who are able to provide the value requested.

		#### Bugs


		+ Response 200

		The response has been truncated to a single ndjson object, as the responses are streamed.

Added Group dht #44

Added Group dht #44

Conversation

RichardLitt commented Feb 6, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dignifiedquire commented Feb 19, 2016

RichardLitt commented Feb 19, 2016

daviddias commented Feb 19, 2016

RichardLitt commented Mar 3, 2016

RichardLitt commented Mar 9, 2016

RichardLitt commented Apr 13, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daviddias commented Apr 19, 2016

Added Group `dht` #44

Added Group `dht` #44