Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove duplicate code #308

Merged
merged 2 commits into from
Feb 8, 2023
Merged

test: remove duplicate code #308

merged 2 commits into from
Feb 8, 2023

Conversation

simlecode
Copy link
Collaborator

@simlecode simlecode commented Feb 8, 2023

关联的Issues (Related Issues)

close

改动 (Proposed Changes)

移除测试中重复的代码

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@codecov-commenter
Copy link

Codecov Report

Merging #308 (41b5b4c) into master (de5d8ed) will decrease coverage by 0.47%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #308      +/-   ##
==========================================
- Coverage   54.31%   53.84%   -0.47%     
==========================================
  Files          69       69              
  Lines        7022     7022              
==========================================
- Hits         3814     3781      -33     
- Misses       2909     2940      +31     
- Partials      299      301       +2     
Flag Coverage Δ
unittests 53.84% <100.00%> (-0.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
models/mysql/message.go 77.56% <100.00%> (ø)
models/sqlite/message.go 81.54% <100.00%> (ø)
testhelper/mock_data.go 81.25% <100.00%> (ø)
testhelper/mock_node_repo.go 26.31% <0.00%> (-45.62%) ⬇️
service/node_service.go 70.00% <0.00%> (-10.00%) ⬇️
service/address_service.go 60.86% <0.00%> (-2.61%) ⬇️
service/message_service.go 59.80% <0.00%> (-0.15%) ⬇️

@simlecode simlecode self-assigned this Feb 8, 2023
Copy link
Contributor

@diwufeiwen diwufeiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diwufeiwen diwufeiwen merged commit 13515f6 into master Feb 8, 2023
@diwufeiwen diwufeiwen deleted the chore/duplicate-code branch February 8, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants