Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add create-react-app-example #35

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

achingbrain
Copy link
Contributor

@achingbrain achingbrain commented Apr 5, 2023

Currently blocked because create-react-app doesn't support monorepos.

In a monorepo dependencies are hoisted to the root, but CRA requires loading them from the project directory.

Failed to compile.

Module not found: Error: You attempted to import /Users/alex/Documents/Workspaces/ipfs-examples/helia-examples/node_modules/react-refresh/runtime.js which falls outside of the project src/ directory. Relative imports outside of src/ are not supported.
You can either move it inside src/, or add a symlink to it from project's node_modules/.

Refs: facebook/create-react-app#1333

@SgtPooki
Copy link
Contributor

create react app is more painful than it's worth and I think we should skip adding this example entirely tbh.

there are enough other examples that users can throw into CRA if they want

@achingbrain
Copy link
Contributor Author

Maybe I'm being optimistic but I like to think this will work one day..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants