Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency to cob_obstacle_distance_moveit #478

Merged
merged 2 commits into from
Aug 10, 2016

Conversation

ipa-nhg
Copy link
Member

@ipa-nhg ipa-nhg commented May 24, 2016

No description provided.

@ipa-nhg
Copy link
Member Author

ipa-nhg commented May 24, 2016

As discussed: #468

@mathias-luedtke
Copy link
Contributor

not sure if we should remove it if cob_twist_controller uses it.
@ipa-fxm-cm: what happens if the controller is run without the distance monitor per default?

@MaChristoph
Copy link
Collaborator

@ipa-mdl : If the twist_controller is started without the distance informations then the collision avoidance won't work. The cob_obstacle_distance_moveit node is the "new" one and replaces the "old" cob_obstacle_distance node, since it's computation time is much more efficient. So you might delete the cob_obstacle_distance dependency instead of the cob_obstacle_distance_moveit dep.

@floweisshardt
Copy link
Member

@ipa-nhg: what's the status here? can this be merged?

@floweisshardt
Copy link
Member

CR: OK, merge conflicts solved in #517

@ipa-nhg ipa-nhg merged commit ecb466b into ipa320:indigo_dev Aug 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants