Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pytest warnings #61

Merged
merged 4 commits into from
Feb 12, 2024
Merged

Fix pytest warnings #61

merged 4 commits into from
Feb 12, 2024

Conversation

fbjorn
Copy link
Contributor

@fbjorn fbjorn commented Feb 12, 2024 

....
firedantic/tests/tests_sync/test_ttl_policy.py::test_set_up_ttl_policies_new_policy PASSED [ 97%]
firedantic/tests/tests_sync/test_ttl_policy.py::test_set_up_ttl_policies_other_states[state0] PASSED [ 98%]
firedantic/tests/tests_sync/test_ttl_policy.py::test_set_up_ttl_policies_other_states[state1] PASSED [ 99%]
firedantic/tests/tests_sync/test_ttl_policy.py::test_set_up_ttl_policies_other_states[state2] PASSED [100%]

============================= 117 passed in 1.00s ==============================

Can't fully fix it due to googleapis/python-firestore#804 being open. Had to suppress it for now.

@fbjorn fbjorn linked an issue Feb 12, 2024 that may be closed by this pull request
Warnings about filters using positional arguments #47
Closed
@fbjorn fbjorn merged commit 33a0eb9 into main Feb 12, 2024
4 checks passed
@fbjorn fbjorn deleted the fix/hide-logging branch February 12, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joakimnordling joakimnordling joakimnordling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warnings about filters using positional arguments
2 participants
@fbjorn @joakimnordling