Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Accept completed job for log command #62

Merged
merged 1 commit into from
Feb 28, 2019

Conversation

jerr
Copy link
Contributor

@jerr jerr commented Feb 28, 2019

Small change to accept pod in Succeeded phase.
Attempt to fix #61

The trace pod is completed

$ kubectl get pod kubectl-trace-43db844d-3ae6-11e9-8802-9cb6d0de1923-bkrwj 
NAME                                                       READY   STATUS      RESTARTS   AGE
kubectl-trace-43db844d-3ae6-11e9-8802-9cb6d0de1923-bkrwj   0/1     Completed   0          12m

Let's try to view the output

$ kubectl trace log 43db844d-3ae6-11e9-8802-9cb6d0de1923
kubelet: /sys/fs/cgroup/blkio/kubepods/blkio.throttle.io_serviced
kubelet: /sys/fs/cgroup/memory/kubepods/memory.stat
redis-server: /proc/1/stat
^C
first SIGINT received, now if your program had maps and did not free them it should print them out

The output is displayed. 🙂

@jerr jerr changed the title Accept completed job for log command Fix: Accept completed job for log command Feb 28, 2019
@jerr jerr changed the title Fix: Accept completed job for log command fix: Accept completed job for log command Feb 28, 2019
@fntlnz fntlnz self-requested a review February 28, 2019 09:36
@fntlnz
Copy link
Member

fntlnz commented Feb 28, 2019

Oh good catch @jerr !

Copy link
Member

@fntlnz fntlnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The log command doesn't display anything on a completed trace
2 participants