Images and headers flags for run command #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Notice the This because of the way travis pulls the PR branch. Ie.,
|
|
The CI fail was due to the fact that LDFLAGS can't change a constant, I pushed a fix. @leodido |
Signed-off-by: Leonardo Di Donato <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]> Co-Authored-By: Lorenzo Fontana <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
Signed-off-by: Lorenzo Fontana <[email protected]>
Signed-off-by: Lorenzo Fontana <[email protected]>
…flags Signed-off-by: Lorenzo Fontana <[email protected]>
Signed-off-by: Lorenzo Fontana <[email protected]>
Signed-off-by: Lorenzo Fontana <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #53
Regards #48 too (probably needs to be rebased on top of this or the master if this will be merged, to continue to work on).
This PR introduces the following flags for the run command and behavior:
--imagename(defaulting to "quay.io/fntlnz/kubectl-trace-bpftrace:latest")--init-imagename(defaulting to "quay.io/dalehamel/kubectl-trace-init")--fetch-headers(defaulting to false)Notice that defaults will be changed when we'll have "official" default images.
Furthermore this PR removes from version command the info about the tracerunner image in use since it is not related to the version of kubectl-trace imho.