Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests skeleton #26

Merged
merged 9 commits into from
Jan 9, 2019
Merged

Integration tests skeleton #26

merged 9 commits into from
Jan 9, 2019

Conversation

fntlnz
Copy link
Member

@fntlnz fntlnz commented Jan 6, 2019

Related to #25

What I did

  • Put together an integration testing framework using go-check and kind (the idea is that a test starts kubernetes and then uses the kubectl-trace binary against it)
  • Tested a basic kubectl trace run with no attach

@fntlnz fntlnz force-pushed the feature/integration-tests branch from 623c3a8 to 5aad5f7 Compare January 6, 2019 01:44
@fntlnz fntlnz requested a review from leodido January 6, 2019 09:05
leodido
leodido approved these changes Jan 6, 2019
View reviewed changes
Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome to me.

@fntlnz fntlnz force-pushed the feature/integration-tests branch from 32425f2 to 9cbfd9c Compare January 8, 2019 01:39
@fntlnz fntlnz changed the title WIP: Initial Integration tests Integration tests skeleton Jan 9, 2019
@fntlnz fntlnz merged commit 933a110 into master Jan 9, 2019
@fntlnz fntlnz deleted the feature/integration-tests branch January 9, 2019 08:58
This was referenced Jan 9, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leodido leodido leodido approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fntlnz @leodido