Allow libdebuginfod to be excluded even if present #4308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libdebuginfod support is currently only configurable by the presence of the library itself. Unfortunately, when using the static libraries the libdebuginfod dependency gets propagated to users of bcc (e.g. bpftrace), who would have to require it as well. Introduce ENABLE_LIBDEBUGINFOD to allow overriding libdebuginfod usage from above. This allows bcc users to decide for themselves if they want this dependency.
BurntBrunch
requested review from
drzaeus77,
yonghong-song,
4ast,
davemarchevsky,
goldshtn and
brendangregg
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libdebuginfod support is currently only configurable by the presence of the library itself.
Unfortunately, when using the static libraries the libdebuginfod dependency gets propagated to users of bcc (e.g. bpftrace), who would have to require it as well.
Introduce ENABLE_LIBDEBUGINFOD to allow overriding libdebuginfod usage from above. This allows bcc users to decide for themselves if they want this dependency.
P.S. The bcc pkg-config needs some help - this dependency is not reflected anywhere and not all libraries are listed - but that'll have to be a different PR.