Feature #1008 - Support new TXs for account module in Wallet #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertandrejev
changed the base branch from
master
to
milestone/account-module-support
abefernan
force-pushed
the
feature/#1008-account-txs-support
branch
from
75141eb
to
bd86d88
Compare
abefernan
force-pushed
the
feature/#1008-account-txs-support
branch
from
bd86d88
to
8f8201c
Compare
albertandrejev
force-pushed
the
milestone/account-module-support
branch
from
e366bbf
to
10c70c4
Compare
albertandrejev
commented
Mar 9, 2020
| {iovnames | ||
| .slice() | ||
| .sort((a, b) => { | ||
| if (a.username < b.username) return -1; |
There was a problem hiding this comment.
Better if you will use local compare function.
...
iovnames.slice().sort((a, b) =>
a.username.localeCompare(b.username, undefined, { sensitivity: "base" }),
);
...
Comment on lines
63
to
69
| {starnames | ||
| .slice() | ||
| .sort((a, b) => { | ||
| if (`${a.name}*${a.domain}` < `${b.name}*${b.domain}`) return -1; | ||
| if (`${a.name}*${a.domain}` > `${b.name}*${b.domain}`) return 1; | ||
| return 0; | ||
| }) |
| @@ -85,7 +84,7 @@ withChainsDescribe("E2E > Receive Payment route", () => { | |||
| }, 35000); | |||
| }); | |||
|
|
|||
| describe("Starnames tab", () => { | |||
| describe.skip("Starnames tab", () => { | |||
There was a problem hiding this comment.
Is this ok, or you forgot to remove?
There was a problem hiding this comment.
Since they need some rewrite I prefer to do it as part of #1039.
Comment on lines
7
to
9
| export const REGISTER_IOVNAME_ROUTE = "/register-iovname"; | ||
| export const REGISTER_STARNAME_ROUTE = "/register-starname"; | ||
| export const REGISTER_NAME_ROUTE = "/register-name"; |
There was a problem hiding this comment.
I was thinking about URL naming convention. What do you think if we will place it in order "noun"-"verb". In this case it should be /starname-register. Or even better /starname/register.
There was a problem hiding this comment.
Great, I like the last option since it will open up other operations like /starname/renew or whatever.
abefernan
force-pushed
the
feature/#1008-account-txs-support
branch
from
6f45d89
to
caa21cf
Compare
albertandrejev
commented
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1008.