Fix DPS docker containers log configuration

[Danielius1922]

No description provided.

[coderabbitai]

Walkthrough

The pull request introduces modifications across multiple files related to the Docker build process and logging configurations for the dps-cloud-server application. Key changes include the addition of build arguments for enhanced debugging capabilities, updates to job configurations for improved logging and testing properties, and renaming of logging level variables in the CMake configuration to clarify their association with device provisioning. Additionally, certain flags were removed from the Dockerfile for the debug application, affecting its debugging capabilities.

Changes

Files	Change Summary
.github/workflows/docker-build-publish.yml, .github/workflows/plgd-dps-tests.yml	- Added build arguments for debugging in docker-build-publish.yml: -DPLGD_DEV_DEVICE_PROVISIONING_MAXIMUM_LOG_LEVEL=DEBUG, -DPLGD_DPS_CLOUD_SERVER_DBG_ENABLED=ON. - Modified build_args in plgd-dps-tests.yml to include flags for logging level set to TRACE and enabling test properties.
CMakeLists.txt	- Renamed logging level variables from PLGD_DPS_MAXIMUM_LOG_LEVEL to PLGD_DEV_DEVICE_PROVISIONING_MAXIMUM_LOG_LEVEL and updated related function calls and definitions accordingly.
docker/apps/Dockerfile.dps-cloud-server-debug	- Removed flags -DOC_DEBUG_ENABLED=ON and -DPLGD_DEV_DEVICE_PROVISIONING_TEST_PROPERTIES_ENABLED=ON from the CMake command in the Dockerfile.

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between beca09e and 59731fe.

Files selected for processing (7)

• .github/workflows/docker-build-publish.yml (1 hunks)
• .github/workflows/plgd-dps-tests.yml (1 hunks)
• CMakeLists.txt (1 hunks)
• api/plgd/device-provisioning-client/plgd_dps_apis.c (2 hunks)
• api/plgd/device-provisioning-client/plgd_dps_pki.c (1 hunks)
• api/plgd/device-provisioning-client/plgd_dps_security.c (2 hunks)
• docker/apps/Dockerfile.dps-cloud-server-debug (1 hunks)

Files skipped from review due to trivial changes (2)

• api/plgd/device-provisioning-client/plgd_dps_pki.c
• api/plgd/device-provisioning-client/plgd_dps_security.c

Files skipped from review as they are similar to previous changes (4)

• .github/workflows/docker-build-publish.yml
• .github/workflows/plgd-dps-tests.yml
• CMakeLists.txt
• docker/apps/Dockerfile.dps-cloud-server-debug

Additional comments not posted (2)

api/plgd/device-provisioning-client/plgd_dps_apis.c (2)

33-33: LGTM!

Including the inttypes.h header is a good practice when using format specifiers like PRIu64 for printing 64-bit unsigned integers. This header provides format specifiers and types for printing and scanning specific-width integer types.

---

86-87: LGTM!

The change from %lu to %" PRIu64 is correct and necessary. %" PRIu64 is the appropriate format specifier for 64-bit unsigned integers, while %lu is used for unsigned long integers. This update ensures that the logged value of oc_clock_time_max is accurately represented, enhancing the robustness of the logging mechanism and preventing potential misinterpretations of the logged data type.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[ocf-conformance-test-tool]

🎉 Thank you for your code contribution! To guarantee the change/addition is conformant to the OCF Specification, we would like to ask you to execute OCF Conformance Testing of your change ☝️ when your work is ready to be reviewed.

---

ℹ️ To verify your latest change (00545b6), label this PR with OCF Conformance Testing.

⚠️ Label is removed with every code change.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud