fixup! Fix issues reported by SonarCloud and add tests

iotivity · Apr 16, 2024 · b01ba1c · b01ba1c
1 parent 5a9d272
commit b01ba1c
Show file tree

Hide file tree

Showing 3 changed files with 194 additions and 59 deletions.
diff --git a/security/oc_acl.c b/security/oc_acl.c
@@ -565,6 +565,7 @@ oc_sec_acl_free(void)
 #ifdef OC_DYNAMIC_ALLOCATION
   if (g_aclist != NULL) {
     free(g_aclist);
+    g_aclist = NULL;
   }
 #endif /* OC_DYNAMIC_ALLOCATION */
 }

diff --git a/security/oc_acl_util_internal.h b/security/oc_acl_util_internal.h
@@ -22,15 +22,17 @@
 
 #include "oc_endpoint.h"
 #include "oc_ri.h"
+#include "util/oc_compiler.h"
 
 #include <stdbool.h>
 
 #ifdef __cplusplus
 extern "C" {
 #endif
 
+/** Check method access to given resource */
 bool oc_sec_check_acl(oc_method_t method, const oc_resource_t *resource,
-                      const oc_endpoint_t *endpoint);
+                      const oc_endpoint_t *endpoint) OC_NONNULL();
 
 #ifdef __cplusplus
 }