fixup! Fix issues reported by Coverity

iotivity · Sep 26, 2024 · 9feb9ae · 9feb9ae
1 parent 1602616
commit 9feb9ae
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/api/oc_endpoint.c b/api/oc_endpoint.c
@@ -171,7 +171,10 @@ oc_endpoint_to_cstring(const oc_endpoint_t *endpoint, char *buffer,
     return -1;
   }
   // overflow check for coverity scan
-  assert(len <= INT_MAX - written && "Integer overflow detected");
+  // assert(len <= INT_MAX - written && "Integer overflow detected");
+  if (len > INT_MAX - written) {
+    return -1;
+  }
   return len + written;
 }
 

diff --git a/util/jsmn/jsmn.c b/util/jsmn/jsmn.c
@@ -249,7 +249,10 @@ jsmn_parse_next_char(jsmn_parser_t *parser, jsmntok_t *token, const char *js,
       return r;
     }
     // overflow check for coverity scan
-    assert(count <= INT_MAX - r && "Integer overflow detected");
+    // assert(count <= INT_MAX - r && "Integer overflow detected");
+    if (count > INT_MAX - r) {
+      return -1
+    }
     count += r;
     break;
   }
@@ -299,7 +302,10 @@ jsmn_parse(jsmn_parser_t *parser, const char *js, const size_t len,
       return r;
     }
     // overflow check for coverity scan
-    assert(count <= INT_MAX - r && "Integer overflow detected");
+    // assert(count <= INT_MAX - r && "Integer overflow detected");
+    if (count > INT_MAX - r) {
+      return -1
+    }
     count += r;
   }